2022-04-21 Rohit Code Review

 

Meaningless name - better SortableFlightPlanPOIs

image-20220421232912371

 

Why 2 functions, if diffenece only single wrapper tag should have been one function

image-20220421233105365

 

Meaningless name - never use "data"!!

image-20220421233200214

 

Why opacity? any reason?

image-20220421233311742

 

Do not mix handleChange and onChange naming in same project. onChange - does not tell that it is actually on Order change

image-20220421233409622

 

If in project we have is_enabled then do not use enabled

image-20220421233825924

 

Why this, if you add such things please write comment why there is it

image-20220421235451708

 

Aways before calling parent functon make sure it exists

image-20220422000241770

 

 

Why there is loading in flight dialog

image-20220422001911500

 

🔴 What is this? this not nodejs app in any way!

image-20220422010413943

 

🔴 If you have naming dialog, please implement it also for creating POIs not only for rename image-20220422002004510